Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _document and getInitialProps with React 18 #35736

Merged
merged 10 commits into from
Mar 30, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 30, 2022

Fixes #35711

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment was marked as resolved.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Mar 30, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/1508 Change
buildDuration 15.4s 15.6s ⚠️ +180ms
buildDurationCached 6.1s 6s -57ms
nodeModulesSize 467 MB 467 MB ⚠️ +2.31 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/1508 Change
/ failed reqs 0 0
/ total time (seconds) 2.985 3.015 ⚠️ +0.03
/ avg req/sec 837.56 829.23 ⚠️ -8.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.213 1.197 -0.02
/error-in-render avg req/sec 2061.55 2087.93 +26.38
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1508 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1508 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1508 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1508 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1508 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/1508 Change
buildDuration 18.9s 18.9s -2ms
buildDurationCached 6.1s 6.1s ⚠️ +24ms
nodeModulesSize 467 MB 467 MB ⚠️ +2.31 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/1508 Change
/ failed reqs 0 0
/ total time (seconds) 2.943 2.972 ⚠️ +0.03
/ avg req/sec 849.58 841.13 ⚠️ -8.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.24 1.225 -0.01
/error-in-render avg req/sec 2015.8 2040.49 +24.69
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/1508 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.7 kB 72.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/1508 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/1508 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/1508 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/1508 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6d40e6e

@ijjk ijjk merged commit 600e0b3 into vercel:canary Mar 30, 2022
@shuding shuding deleted the shu/1508 branch March 30, 2022 16:10
@ijjk ijjk mentioned this pull request Mar 30, 2022
3 tasks
kodiakhq bot pushed a commit that referenced this pull request Mar 31, 2022
This is a follow-up to #35736 that ensures we use the styles from `_document.getInitialProps` instead of only applying the `styled-jsx` styles. 

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: #35758
x-ref: #35736
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_document.js does not work for React.JS v18
3 participants